-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal: add scrollable functionality v2 #367
Modal: add scrollable functionality v2 #367
Conversation
🦋 Changeset detectedLatest commit: 3ea0c64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9ce3894
to
3ea0c64
Compare
top: 0; | ||
justify-content: center; | ||
position: absolute; | ||
inset: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, i didnt know this was a thing. this is how we remove all my magic numbers
Follow up from @somethiiing 's pr: #364
Changes
classic
forkingVideo
syntax-modal-scroll-v2.mp4